Dialog: Add filter size argument, remove NULL termination #9856
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This replaces the handling of the length of the
filters
arguments from null-terminated to a separate size argument, which should be less bug-prone.I've also removed the case where if a user selected a file without selecting any filter, it would return the size of the array. It now returns -1, the same as when the platform doesn't support fetching the chosen filter. I'm not sure there's any difference that's relevant for the downstream developers.
Note: I've had to manually update the dynapi files to accomodate for the new arguments. Running
gendynapi.py
did not update the arguments, and it added two thread-related functions which seem to have been forgotten.Existing Issue(s)
Closes #9693