Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-time tests are not run on ci #379

Closed
madebr opened this issue Aug 1, 2023 · 4 comments
Closed

build-time tests are not run on ci #379

madebr opened this issue Aug 1, 2023 · 4 comments

Comments

@madebr
Copy link
Contributor

madebr commented Aug 1, 2023

Looking into it atm.

Also, testimage --filter Images is currently failing.
The output contains a lot of:

ERROR: 08/01/23 17:26:46: Assert 'Loading reference should succeed (Parameter 'src' is invalid)': Failed
@slouken
Copy link
Collaborator

slouken commented Aug 1, 2023

That sounds like the test data isn't where the program expects

@madebr
Copy link
Contributor Author

madebr commented Aug 1, 2023

Looks like only the xcf image decoder is failing:

ERROR: 08/01/23 23:25:18: Assert 'Surface differed from reference by at most 0 in 966 pixels': Failed
INFO: /home/maarten/projects/SDL_image/cmake-build-debug/test/sample.xcf:

@slouken
Copy link
Collaborator

slouken commented Aug 2, 2023

Good catch, fixed in 698f2cf

@madebr
Copy link
Contributor Author

madebr commented Aug 9, 2023

Since ba43aa3, the tests are run on ci.

@madebr madebr closed this as completed Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slouken @madebr