Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description of src_ratio field in api_misc section of the website is wrong #56

Closed
Ashymad opened this issue Apr 3, 2019 · 1 comment
Closed

Description of src_ratio field in api_misc section of the website is wrong #56

Ashymad opened this issue Apr 3, 2019 · 1 comment

Comments

@Ashymad
Copy link
Contributor

Ashymad commented Apr 3, 2019

From: http://www.mega-nerd.com/SRC/api_misc.html#SRC_DATA

Finally, the src_ratio field specifies the conversion ratio defined as the input sample rate divided by the output sample rate.

While it should be "output sample rate divided by input sample rate". Elsewhere in the documentation it is specified correctly:

src_ratio : Equal to output_sample_rate / input_sample_rate.
@erikd
Copy link
Member

erikd commented Apr 3, 2019

Would be more than happy to get a patch for this.

Ashymad added a commit to Ashymad/libsamplerate that referenced this issue Apr 3, 2019
@Ashymad
Change docs for src_ratio
faa3ef5 
Fixes libsndfile#56
Ashymad added a commit to Ashymad/libsamplerate that referenced this issue Apr 3, 2019
@Ashymad
Change docs for src_ratio
1fdda87 
Fixes libsndfile#56
@Ashymad Ashymad mentioned this issue Apr 3, 2019
Merged
@erikd erikd closed this as completed in #57 Apr 3, 2019
erikd pushed a commit that referenced this issue Apr 3, 2019
@Ashymad @erikd
Change docs for src_ratio
ed07222 
Fixes #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@erikd @Ashymad