Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: NewTxFromReader and VarInt datatype #88

Merged
merged 7 commits into from
Dec 2, 2021

Conversation

tigh-latte
Copy link
Contributor

Add NewTxFromReader that builds and returns a transaction from an io.Reader

Also added VarInt data type for cleaner handling of variable ints.

@mergify mergify bot added the enhancement New feature or request label Dec 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #88 (1857737) into master (792a281) will decrease coverage by 0.72%.
The diff coverage is 72.25%.

❗ Current head 1857737 differs from pull request most recent head d9d468a. Consider uploading reports for the commit d9d468a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   84.51%   83.78%   -0.73%     
==========================================
  Files          35       35              
  Lines        3512     3627     +115     
==========================================
+ Hits         2968     3039      +71     
- Misses        396      424      +28     
- Partials      148      164      +16     
Impacted Files Coverage Δ
varint.go 73.77% <65.85%> (-26.23%) ⬇️
input.go 81.08% <71.42%> (-9.17%) ⬇️
tx.go 78.76% <72.91%> (-1.89%) ⬇️
output.go 86.95% <73.91%> (-13.05%) ⬇️
signaturehash.go 70.86% <100.00%> (ø)
txchange.go 82.75% <100.00%> (ø)
txinput.go 85.26% <100.00%> (ø)
txoutput.go 82.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 792a281...d9d468a. Read the comment docs.

Copy link
Contributor

@theflyingcodr theflyingcodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 83c90f3 into master Dec 2, 2021
@mergify mergify bot deleted the enhancement/tx-from-reader branch December 2, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants