Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error reporting to the MacOS port. #314

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

hardkrash
Copy link
Contributor

Initial implementation of error messages for the macOS port.

Interface mostly copied from the linux port.
Messages probably need some love for the other errors being reported.

@hardkrash
Copy link
Contributor Author

This is to resolve issue #310

@mcuee mcuee added the macOS Related to macOS backend label Aug 1, 2021
mac/hid.c Outdated Show resolved Hide resolved
@Youw
Copy link
Member

Youw commented Jun 12, 2022

Hi @hardkrash,

Are you still up to finish this PR?
I've started some changes for hidraw backend: #428,
those introduce a safe strategy for hid_error and allows to proceed with the implementation for other (this one) backends.

@Youw Youw mentioned this pull request Jun 12, 2022
@mcuee
Copy link
Member

mcuee commented Aug 16, 2022

#428 has been merged.

Copy link
Member

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of updating the implementation:

  • rebased to master/fixed conflicts;
  • updated error messages/error handling a bit;

I don't have a chance to test this well as of yet.
Additional core review is welcome.

@Youw
Copy link
Member

Youw commented Oct 14, 2022

I guess if any objections/improvements - we'll be fixing them in master.

@Youw Youw merged commit f2e2b5b into libusb:master Oct 14, 2022
fengjixuchui added a commit to fengjixuchui/hidapi that referenced this pull request Oct 14, 2022
macOS: Error reporting/hid_error implementation (libusb#314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macOS Related to macOS backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants