Windows: hid_get_feature/input_report return size fix #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It appears when the numbered reports aren't used, WinAPI returns size of the report excluding the data[0] which contains 0, as an indication that numbered reports aren't used; Explicity count that byte in the result. Fixes: #328
Youw
force-pushed
the
win_fix_feature
branch
from
19e809e
to
ad36065
Compare
Closed
mcuee
approved these changes
Sep 27, 2021
|
As mentioned in #328, the fixes for the feature report should be correct. |
|
However, hidapitester can not be used to test the fix to the input report as it uses hid_read_timeout(). |
CEnnis91
added a commit
to smash64-dev/mupen64plus-libretro-nx
that referenced
this pull request
Nov 13, 2021
git subrepo pull custom/dependencies/hidapi subrepo: subdir: "custom/dependencies/hidapi" merged: "b66d7c2c" upstream: origin: "https://github.com/libusb/hidapi.git" branch: "master" commit: "b66d7c2c" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
CEnnis91
added a commit
to smash64-dev/mupen64plus-libretro-nx
that referenced
this pull request
Aug 6, 2022
git subrepo pull custom/dependencies/hidapi subrepo: subdir: "custom/dependencies/hidapi" merged: "b66d7c2c" upstream: origin: "https://github.com/libusb/hidapi.git" branch: "master" commit: "b66d7c2c" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinAPI returns size of the report excluding the data[0] which contains 0,
as an indication that numbered reports aren't used;
Explicity count that byte in the result.
Fixes: #328