Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Test Continous integration, should fail for this PR #34

Closed
wants to merge 1 commit into from

Conversation

Qbicz
Copy link
Member

@Qbicz Qbicz commented Jun 26, 2019

No description provided.

@Qbicz
Copy link
Member Author

Qbicz commented Jun 26, 2019

@z3ntu Sourcehut jobs have passed, but they should have failed. In https://builds.sr.ht/~qbicz/job/72033 I see that the commit and PR is picked up correctly, so what could be the issue here?

@Qbicz Qbicz changed the title Test Continous integration, should fail for this PR [DNM] Test Continous integration, should fail for this PR Jun 26, 2019
@Qbicz Qbicz mentioned this pull request Jun 27, 2019
@Qbicz
Copy link
Member Author

Qbicz commented Jun 27, 2019

I compared CI working on @z3ntu branch and the CI that was running for this PR and I see the git checkout step is missing. So Sourcehut builds master instead of the branch in the PR:
https://builds.sr.ht/~z3ntu/job/70855
https://builds.sr.ht/~qbicz/job/72033

Maybe I have misconfigured something, I will double check.

@Qbicz
Copy link
Member Author

Qbicz commented Jun 27, 2019

I have setup libusb/hidapi::github_pr_to_build on sr.ht. There are no more options there, everything is configured in .yml file. Should I also set up the build for every commit?

@z3ntu
Copy link
Collaborator

z3ntu commented Jun 27, 2019

This could be caused by your fork not being called "hidapi" but "hidapi-1", at least saw something similar before when my repo was called hidapi-1... I'll look into it

@z3ntu
Copy link
Collaborator

z3ntu commented Jun 27, 2019

Confirmed, that's an issue in dispatch.sr.ht+builds.sr.ht, but I have a proposal on how to fix this written to the sr.ht mailing list (see https://todo.sr.ht/~sircmpwn/dispatch.sr.ht/34 & https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C1736964.CSqEvfHbRm%40g550jk%3E)

@Qbicz
Copy link
Member Author

Qbicz commented Jun 30, 2019

@z3ntu thanks for the hint and for the investigation. I have renamed my fork to hidapi and retriggered. Now the correct commit is being checked out and CI fails as it should be for this change.
https://builds.sr.ht/~qbicz/job/72786

@Qbicz
Copy link
Member Author

Qbicz commented Jun 30, 2019

CI test successful. Closing.

@Qbicz Qbicz closed this Jun 30, 2019
@Qbicz Qbicz mentioned this pull request Jun 30, 2019
@z3ntu
Copy link
Collaborator

z3ntu commented Jul 1, 2019

@Qbicz The patches for supporting forks with a different name are merged now so it should work fine in the future :)

@mcuee mcuee added build system/CI Anything related to building the project or running on CI don't_merge Don't merge this PR as is labels Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system/CI Anything related to building the project or running on CI don't_merge Don't merge this PR as is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants