Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported code from SetupApi to CfgMgr32 #362

Merged
merged 4 commits into from
Jan 21, 2022
Merged

Ported code from SetupApi to CfgMgr32 #362

merged 4 commits into from
Jan 21, 2022

Conversation

DJm00n
Copy link
Contributor

@DJm00n DJm00n commented Dec 23, 2021 •
edited
Loading

Youw
Youw reviewed Dec 24, 2021
View reviewed changes
Copy link
Member

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you've removed dependency on SetupAPI - we should remove link dependency on it too: from CMakeLists, autotools and vsproj files

windows/hid.c Outdated Show resolved Hide resolved
@Youw
Copy link
Member

Youw commented Dec 24, 2021

This is nice refactoring, thanks.

@mcuee mcuee added the Windows Related to Windows backend label Dec 28, 2021
@DJm00n DJm00n force-pushed the remove_setup_api branch 2 times, most recently from 9b7a293 to 0eea360 Compare December 28, 2021 18:24
Youw
Youw reviewed Dec 29, 2021
View reviewed changes
windows/hid.c Outdated Show resolved Hide resolved
Youw
Youw reviewed Dec 29, 2021
View reviewed changes
Copy link
Member

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all of the link dependencies on cfgmgr32 and hid from all of build scripts.

windows/hid.c Outdated Show resolved Hide resolved
windows/CMakeLists.txt Outdated Show resolved Hide resolved
@DJm00n DJm00n requested a review from Youw January 6, 2022 15:59
Youw
Youw reviewed Jan 8, 2022
View reviewed changes
Copy link
Member

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for the potential leak - looks good

windows/hid.c Outdated Show resolved Hide resolved
windows/hid.c Show resolved Hide resolved
@Youw Youw merged commit fe9a2a2 into libusb:master Jan 21, 2022
@DJm00n DJm00n deleted the remove_setup_api branch January 26, 2022 10:15
@Sunbreak
Copy link

A little curious why porting SetupApi to CfgMgr32?

UWP will continue to be supported with "bug, reliability, and security fixes", but Windows App SDK is the "single path forward"

flutter/flutter#14967 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youw Youw Youw approved these changes

Assignees
No one assigned
Labels
Windows Related to Windows backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DJm00n @Youw @Sunbreak @mcuee