Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Do not install pkgconfig #639

Merged
merged 1 commit into from
Nov 16, 2023
Merged

CMake: Do not install pkgconfig #639

merged 1 commit into from
Nov 16, 2023

Conversation

cmorty
Copy link
Contributor

@cmorty cmorty commented Nov 16, 2023

If HIDAPI_INSTALL_TARGETS is set to off, pkgconfig is still installed. This a problem when statically linking against libhid and then using CMake's install-feature.

If HIDAPI_INSTALL_TARGETS is set to off, pkgconfig is still installed.
This a problem when statically linking against hidapi and then using
CMake's install-feature.
@mcuee mcuee added build system/CI Anything related to building the project or running on CI CMake Related to CMake build system and removed build system/CI Anything related to building the project or running on CI labels Nov 16, 2023
Copy link
Member

@Youw Youw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@Youw Youw merged commit 9b507ed into libusb:master Nov 16, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Related to CMake build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants