Fix empty else in configure script

[Florin-Popescu]

Hello!

After running bootstrap.sh on my MSYS2 installation, the configure script couldn't be run due to a syntax error with an empty else.
I tracked it down to the $5 which I removed in this commit. With it removed, it builds for me successfully.
Don't know how this was supposed to be used. If it's in fact needed please tell me how to fix it and remove this pull request.

[mcuee]

Which version of MSYS2 installation?

From MSYS2 I can see no patch is needed for libusb-compat-git package.
https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-libusb-compat-git/PKGBUILD

[Florin-Popescu]

I'm using msys2-x86_64-20210105. It may be due to me building in MSYS2 MSYS system, which I understand is more POSIX than mingw-w64 and has a different compiler toolchain.

[mcuee]

Just wondering why you need to build under MSys2 MSys subsystem.

[Florin-Popescu]

I am building a fork of AVARICE, GDB debug server for AVR micros. It uses termios.h and maybe some other POSIX APIs which are not available under Windows without MSYS or Cygwin. It also uses the old libusb 0.1 APIs so the cleanest way that I found to get everything working is to build libusb 1.0 and this compatibility layer from source under MSYS2, after which avarice itself can be built.

[Neustradamus]

Dear @libusb team,

It is possible to look this PR?

[mcuee]

As it is this pull request can not be accepted.

@Florin-Popescu Can you remove the Debian stuff and update the pull request. Thanks.

@tormodvolden and @hjelmn
Please take a look at the configure script to see if it is acceptable or not. Thanks.

[Florin-Popescu]

Cleaned it up. Should've used a branch for the PR, didn't realize that my changes were making it into here.

[mcuee]

Strange that CI build failed.
Maybe we should add github action as well for Linux, macOS and MinGW.

[Florin-Popescu]

It failed on macOS from what I remember because of an error finding some tool with homebrew. But it looks like it can't retrieve the build logs anymore. It was a long time ago...

Is it possible to retrigger the CI build?

[mcuee]

@Florin-Popescu
I have deleted the outdated Travis-CI build and created the Linux and macOS github action. Please push again to see if it triggers the github actions.

[mcuee]

@Florin-Popescu
I've tested your pull request under my fork and it works fine for Linux and macOS github action build.

• https://github.com/mcuee/libusb-compat-0.1/pull/1

BTW, the failure on the msys2 build is my msys2.yml problem -- I have not figured out what the issue is.

[mcuee]

It seems to be okay so I will take the liberty to merge this one.