osx,stream: retry sending handle on EMSGSIZE error #1739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found out about this solution here though I understand this be problematic as it can lead to a busy loop. |
|
Stress tests of the test from nodejs/node#14828:
|
cjihrig
approved these changes
Feb 13, 2018
src/unix/stream.c
Outdated
| @@ -859,7 +859,16 @@ static void uv__write(uv_stream_t* stream) { | |||
| } | |||
|
|
|||
| if (n < 0) { | |||
| if (errno != EAGAIN && errno != EWOULDBLOCK && errno != ENOBUFS) { | |||
| if (errno != EAGAIN && errno != EWOULDBLOCK && errno != ENOBUFS | |||
There was a problem hiding this comment.
Indentation looks off here.
src/unix/stream.c
Outdated
| @@ -859,7 +859,16 @@ static void uv__write(uv_stream_t* stream) { | |||
| } | |||
|
|
|||
| if (n < 0) { | |||
| if (errno != EAGAIN && errno != EWOULDBLOCK && errno != ENOBUFS) { | |||
| if (errno != EAGAIN && errno != EWOULDBLOCK && errno != ENOBUFS | |||
| #if defined(__APPLE__) | |||
There was a problem hiding this comment.
I'm not sure how other feel about this, but I'm not a huge fan of have an ifdef in the middle of a statement like this.
On OSX when sending handles via `sendmsg()` it can return `EMSGSIZE` if there isn't room in the socket output buffer to store the whole message. In that's the case, return control to the loop and try again in the next iteration. Fixes: nodejs/node#14828
santigimeno
force-pushed
the
osx_msgsize
branch
from
1794f4b
to
95bfd16
Compare
|
PR updated to use a macro. @cjihrig what do you think? |
|
I'm good with the macro. |
cjihrig
pushed a commit
that referenced
this pull request
Feb 21, 2018
On OSX when sending handles via `sendmsg()` it can return `EMSGSIZE` if there isn't room in the socket output buffer to store the whole message. If that's the case, return control to the loop and try again in the next iteration. Fixes: nodejs/node#14828 PR-URL: #1739 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in e6168df. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On OSX when sending handles via
sendmsg()it can returnEMSGSIZEifthere isn't room in the socket output buffer to store the whole message.
In that's the case, return control to the loop and try again in the next
iteration.
Fixes: nodejs/node#14828