win: fix fs.stat for AppExecLink #3874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling uv_fs_stat for AppExecLink reparse points (eg. LOCALAPPDATA\Microsoft\\WindowsApps\MicrosoftEdge.exe) was failing with EACCES code. This change enables making that call without failure. Also added a test covering this behavior. Refs: nodejs/node#36790 Refs: nodejs/node#33024 Refs: libuv#2812
vtjnash
requested changes
Jan 9, 2023
|
Please see issue comment that implemented the fix and closed this issue originally: nodejs/node#33024 (comment) |
|
Apologies for responding only now. TL;DR Closing this PR was the right thing to do.
Not completely, but overall yes. This would change the way a handle to a file is created. Afterward, in Unfortunately, all tests passed, so this issue was caught during the review. Adding a test for comparing stat and lstat results could help prevent this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
uv_fs_statfor AppExecLink reparse points (eg.LOCALAPPDATA\Microsoft\\WindowsApps\MicrosoftEdge.exeor any other application from that directory) was failing with EACCES code. Under the hood, what was failing was theCreateFileWfunction becauseFILE_FLAG_OPEN_REPARSE_POINTwas not used in that case, unlike in theuv_fs_lstat.Based on documentation using the
FILE_FLAG_OPEN_REPARSE_POINTflag is safe because "If the file is not a reparse point, then this flag is ignored". As a result, this change will not have a negative (nor any other) effect on all other cases when the file is not an AppExecLink reparse point.This PR also adds a test covering this behavior.
Refs: nodejs/node#36790
Refs: nodejs/node#33024
Refs: #2812