Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: disable io_uring on ppc64 and ppc64le #4285

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

bradking
Copy link
Contributor

Since io_uring support was added, libuv's signal handler randomly segfaults on
ppc64le when interrupting epoll_pwait. Disable it pending further investigation.

Issue: #4283

Copy link
Member

@santigimeno santigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change. One question: by @glaubitz comments in #4283 I was implying the failures also happened in ppc64 as the cfarm203 box has that architecture. Is this correct or only happened in ppc64le?

@glaubitz
Copy link

I'm fine with this change. One question: by @glaubitz comments in #4283 I was implying the failures also happened in ppc64 as the cfarm203 box has that architecture. Is this correct or only happened in ppc64le?

It affects both ppc64le and ppc64 (both little-endian and big-endian).

@bradking bradking changed the title linux: disable io_uring on ppc64le linux: disable io_uring on ppc64 and ppc64le Jan 12, 2024
Since `io_uring` support was added, libuv's signal handler randomly
segfaults on ppc64 when interrupting `epoll_pwait`.  Disable it
pending further investigation.

Issue: libuv#4283
@bradking
Copy link
Contributor Author

Thanks. I updated the PR to cover both ppc64 and ppc64le.

@santigimeno santigimeno merged commit 3b6a1a1 into libuv:v1.x Jan 13, 2024
26 checks passed
@bradking bradking deleted the linux-ppc64le-no-io_uring branch January 13, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants