-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 8.7 #1
Add 8.7 #1
Conversation
jcupitt
commented
Jul 31, 2018
- add an 8.7 dir
- revise dockerfile to remove env vars and set an entrypoint
- revise scripts to use args rather than env vars
- update imagemagick
- move wine test outside container
- revised dockerfile to remove env vars and set an entrypoint - do wine test outside container - revised scripts to not pass args by env vars
they've removed another tarball
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Added a small note. I'll merge it when the merge conflicts are resolved.
By the way,
Would it not be better if this repo is incorporated in build-win64? I could open a PR or transfer the ownership of this repo to you.
8.7/.update-timestamp
Outdated
@@ -0,0 +1 @@ | |||
1490108997 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be git ignored?
and ignore
OK, conflicts fixed, and I remove that stray file. I'm not sure about merging this into my build-win64. I'm still deciding now I feel about MXE. I can see some advantages, but .... uuurk, gnu make. I'm planning to move all of my vips stuff into the libvips org: I've just been too lazy. Perhaps it could go in there? |
Indeed, MXE has advantages but also its disadvantages. Personally, I find it easier to use than JHBuild and it also seems a bit faster (when I used JHBuild it was constantly rebuilding all dependencies). Wow, moving all vips stuff into the libvips organization sounds great. I think this repo would fit well there. |