Support non-string header values that stringify #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid leaking secrets in stack traces, my team has started passing secrets as blessed coderefs, similar to Secret.pm in this commit. One of the spots we have a secret is in a header value. I found that passing such an object to HTTP::Headers sort of works already, but when LWP tries to use it in the request it calls clone() which fails due to Storable throwing "Can't store CODE items". Instead, this changes us to use Clone::clone which seems to provide similar functionality while supporting this use case.
|
@atoomic do you foresee any issues with swapping out |
|
Using Clone seems fine to me here |
|
Seems fine to me here as well. |
|
I think we should be careful when we introduce new XS dependencies. |
|
That sounds good! I did that. Another thought is we could potentially drop the code path using Storable/Clone all together, given it's optional. |
|
@horgh Thanks. LGTM |
oalders
approved these changes
May 7, 2020
|
The AppVeyor failures are happening in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid leaking secrets in stack traces, my team has started passing
secrets as blessed coderefs, similar to Secret.pm in this commit. One of
the spots we have a secret is in a header value.
I found that passing such an object to HTTP::Headers sort of works
already, but when LWP tries to use it in the request it calls clone()
which fails due to Storable throwing "Can't store CODE items".
Instead, this changes us to use Clone::clone which seems to provide
similar functionality while supporting this use case.
I'm not sure if there's important functional implications though between Storable and Clone.
Thank you!