fix https_proxy problem for IO::Socket::SSL and Net::SSL, includes extensive test (Part#2) #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This goes together with change to libwww-perl cb80c2ddb7 - new method _upgrade_sock in LWP::Protocol::https, but only if the default SSL library IO::Socket::SSL is used (e.g. can start_SSL). This enables LWP::Protocol::http to establish tunnel and upgrade an existing socket. - extensive test t/https_proxy.t to make sure that LWP behaves correctly. test can be run with IO::Socket::SSL and Net::SSL as backend by forcing library with environment PERL_NET_HTTPS_SSL_SOCKET_CLASS
gisle
added a commit
that referenced
this pull request
Nov 21, 2013
fix https_proxy problem for IO::Socket::SSL and Net::SSL, includes extensive test (Part#2)
|
@gisle thanks for the merge. Could you publish a new release for libwww-perl and lwp-protocol-https ? Once this is done, we will be able to close a lot of bug in Debian that are plaguing users stuck behind a firewall. (I'm pretty sure that other distros are in a similar situation) All the best |
|
@gisle Do you have a target date for publishing this to CPAN? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this change fixes the behavior of https_proxy.
Current behavior: send unencrypted requests with https:// URLs to specified proxy
Correct behavior: create encrypted tunnel to proxy and send requests within
This is part#2 of the change, the rest is in libwww-perl
Regards,
Steffen Ullrich (maintainer IO::Socket::SSL)