Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Nan 2.0.x #330

Merged
merged 5 commits into from
Aug 27, 2015
Merged

Migration to Nan 2.0.x #330

merged 5 commits into from
Aug 27, 2015

Conversation

jdesboeufs
Copy link
Contributor

  • Make build pass
  • Make tests pass
  • Compatibility with node-v0.8

@defunctzombie
Copy link
Collaborator

@jdesboeufs such amaze!

FYI if you are having issues with the travis builds check out this reference travis config:
https://github.com/ncb000gt/node.bcrypt.js/blob/master/.travis.yml

@jdesboeufs
Copy link
Contributor Author

Thank you!

For now it build on my Mac but tests end with segfault.

@defunctzombie
Copy link
Collaborator

for the final tidbit, might want to check out these lines from bcrypt
https://github.com/ncb000gt/node.bcrypt.js/blob/master/src/bcrypt_node.cc#L343-L353

@jdesboeufs
Copy link
Contributor Author

It's a bit tricky for "classes".
For now I don't understand how to deal with FunctionTemplate and Export in
this case.
Le jeu. 27 août 2015 à 03:18, Roman Shtylman notifications@github.com a
écrit :

for the final tidbit, might want to check out these lines from bcrypt

https://github.com/ncb000gt/node.bcrypt.js/blob/master/src/bcrypt_node.cc#L343-L353


Reply to this email directly or view it on GitHub
#330 (comment).

@defunctzombie
Copy link
Collaborator

@jdesboeufs
https://gist.github.com/defunctzombie/b24252cb034ecfb6f787

See if that gets you any closer. Seems to produce good results for me.

@jdesboeufs jdesboeufs changed the title [WIP] Migrate to Nan 2.0.x Migration to Nan 2.0.x Aug 27, 2015
@jdesboeufs
Copy link
Contributor Author

Thank you @defunctzombie :)
libxmljs is now compatible with iojs-v3 !

@defunctzombie
Copy link
Collaborator

This is fantastic! Thank you very much for taking the initiative and pushing this through!

defunctzombie added a commit that referenced this pull request Aug 27, 2015
@defunctzombie defunctzombie merged commit 8da4a96 into libxmljs:master Aug 27, 2015
@jdesboeufs jdesboeufs deleted the nan-2.x branch August 27, 2015 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants