New ItemSelector Widget (SingleItemSelector, MultiItemSelector) - libyui part #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschnell
reviewed
Sep 19, 2019
aschnell
reviewed
Sep 19, 2019
aschnell
reviewed
Sep 19, 2019
aschnell
reviewed
Sep 19, 2019
|
As discussed in the daily meeting, bumping the version to 3.8.0. I had to force-push for that. |
shundhammer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
https://trello.com/c/7qI1AAvN/1300-5-libyui-1-of-n-selection-widget
Bugzilla
Bug: System roles are not properly rendered in graphical installation
https://bugzilla.suse.com/show_bug.cgi?id=1084674
Bug: selection box auto scrolls incorrectly
https://bugzilla.suse.com/show_bug.cgi?id=1083207
Bug: UX regression in system role selection (mainly ncurses)
https://bugzilla.suse.com/show_bug.cgi?id=1086187
Mockup Screenshot
Description
This is a new widget for a scrollable 1-of-n or n-of-m selection with not only a simple text for each item, but a heading text and a (possibly multi-line, even rich text) description.
This is the libyui part of it, providing the base class
YItemSelectorand factory methods inYWidgetFactory.Other Changes
Code cleanup: Cleaned up 10 years of cruft in the UI (incompatible indentation etc.).
Reverted insane change of
std::everything for common data types even in the.ccfiles. There is absolutely no need to clutter even the C++ implementation files with that; it just makes the code less readable. Now again using plainstringandendlin the.ccfiles again instead ofstd::stringandstd::endl. This commit from 2012 should never have been accepted.While it might make sense to some extent for
.hfiles to not haveusing std::something, it is completely insane to demand that in the.ccfiles as well. Even for.hfiles this is questionable: Nobody with sense invents a newstringclass without prefix or whatever because this will automatically clash withstd::stringin a gazillion places.Moved out some of the helper functions from
YDialog.ccto a new fileYDialogHelpers.cc. This was completely misplaced there to begin with.YDialogis one of the most important classes in this library; it is counterproductive to clutter it with unrelated stuff like a convenience dialog that can show help texts or release notes. This needs to go to a separate class soonish.YDialogis much too important to have it cluttered with stuff like that.Related PRs