Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Premove during "confirm move" #15402

Closed
benediktwerner opened this issue May 29, 2024 · 3 comments · Fixed by #15413
Closed

Premove during "confirm move" #15402

benediktwerner opened this issue May 29, 2024 · 3 comments · Fixed by #15413
Labels
bug good first issue Narrow in scope (but not necessarily easy) no scala

Comments

@benediktwerner
Copy link
Member

Exact URL of where the bug happened

Any game

Steps to reproduce the bug

Enable "confirm moves" in the game settings on the right, then make a move and before confirming it, make a premove, then cancel the move. The premove highlight stays on the board.

What did you expect to happen?

Probably shouldn't be able to premove before the move is confirmed.

What happened instead?

see above

Operating system

any

Browser and version (or alternate access method)

any

Additional information

No response

@benediktwerner benediktwerner added bug no scala good first issue Narrow in scope (but not necessarily easy) labels May 29, 2024
@nicvagn
Copy link
Contributor

nicvagn commented May 29, 2024

I have recreated this. I will try and work on this.

@nicvagn
Copy link
Contributor

nicvagn commented May 29, 2024

Found the pre-move logic. Still working on locating how to check if move confirm is on

nicvagn added a commit to nicvagn/lila that referenced this issue May 30, 2024
make it so premoves are canceled when you cancel a move.
@nicvagn
Copy link
Contributor

nicvagn commented May 30, 2024

I think I have a workable solution
see pr

ornicar added a commit that referenced this issue May 31, 2024
fixup: of  Premove during "confirm move" #15402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Narrow in scope (but not necessarily easy) no scala
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants