Translate Chess Insights - Preset

[TheYoBots]

Partially completes #3160

[benediktwerner]

Also, you are missing an import in Presets.scala. You need this at the top next to the other import: import lila.i18n.{ I18nKeys => trans }. Ideally, you should try running it yourself to check that everything looks right. Feel free to ask on Discord if something doesn't work.

And since you mentioned that it partially completes the issue: What's still missing?

[TheYoBots]

Thanks for all your help. Currently this PR only completes a the Presets part of the issue. There is still missing translations for the following files:

• https://github.com/ornicar/lila/blob/master/modules/insight/src/main/Dimension.scala
• https://github.com/ornicar/lila/blob/master/modules/insight/src/main/InsightDate.scala
• https://github.com/ornicar/lila/blob/master/modules/insight/src/main/InsightEntry.scala
• https://github.com/ornicar/lila/blob/master/modules/insight/src/main/Metric.scala
• https://github.com/ornicar/lila/blob/master/modules/insight/src/main/Position.scala

[kraktus]

Also let mods presets untranslated 👍

[benediktwerner]

Hm, still fails to compile.

You are missing the I18nKeys for blurByTimeVariance and howWellDoIMoveEachPieceInTheOpening.

And yeah, you need a Lang in scope when using translations. I think simply changing all the val base = List(...) to def base(implicit lang: Lang) = List(...) and the equivalent for the others should work.

[ornicar]

I don't think insights should be translated.

I'm certain that moderator-only insights presets must not be translated.

[TheYoBots]

Would you like me to revert the moderator translations and keep the rest or simply close?

[ornicar]

Although powerful, insights are too raw to be useful to most people. They could be the foundation of something more comprehensive in the feature, and that thing could then be translated. But not the insights as they are now.