-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically turn the chessboard around to your position when you're analyzing the chessboard #837
Comments
Could you provide some clarification? It seems like you are importing a PGN and want it to rotate based on the player's name from the PGN. Is that correct? Also, please outline the steps to reproduce this problem. |
sorry for not providing that info. steps to reproduce: Thanks @BAW2501 for responding! |
This is a good point. I also agree it would be helpful for imports to auto-adjust analysis based on what color you are playing if it is defined. |
not sure if this would be the desired behavior of the PGN importer as there is no guarantee that user foo in the PGN is foo from Lichess, I'll wait on the input of the main dev before I try my hand at it. |
Well the example game I've imported Lichess was played in Lichess as well. |
I'm a bit confused, are you importing lichess games into lichess? Are they not already in lichess then? |
Interesting workaround. So, what you really want is the comments? If that's the case I think we should address that, rather than adding features for the workaround. I also wonder, how do you even open imported games in the app? |
No it's kinda like a separate issue though And below this is how I import a game |
It's not directly imported though it's exported then imported |
No? So, why don't you just view the game from your profile then? |
It’s an issue I would like to submit later for now but it’s still an issue that makes me export and then import the game in lichess after some games |
So the whole thing is about seeing the all variations in an analysed game? We can add an action to toggle the display of all variations at once (currently it's only possible with a context action for each variation, not the most convenient). Also I don't like to add too much settings, but we could have another analysis settings to decide should be shown from the start or not. |
@veloce commented on Jul 16, 2024, 7:29 AM GMT+8:
no i meant automatically facing black pieces to the player if the player's username matches the Lichess's username |
The import PGN feature is not really meant to import lichess games in the first place... |
It's because that imported games have more info than just viewing from the profile. Please view all of the earlier comments in this thread |
This comment is what I would like to refer to. @veloce the games that are viewed directly from my Lichess profile doesn't have this issue(not rotating if player is black) though but because of this I import games from lichess to lichess |
Have you read my comment: #837 (comment) ? You want to see the comments in italics and the variations (between parenthesis), I got it. |
Sorry for being mean |
I am willing to solve this issue, so I would need developer access. |
You can fork this repository and make nessesary fixes and changes. After that, try to file a pull request to them. They will then decide if it's good or not. |
Closing this as I think the main issue reported here is fixed by #1053 |
I've reviewed the pr, but cannot find as of any sign of the fixes for this issue. Could you be so kind to show me which part of the pr includes that fix? thank you! |
After testing the latest version of lichess beta I find this issue unfixed though I exported the PGN from lichess as me playing black and the board doesn't automatically turn around like I normally do see if I click the game instead of exporting But to see if the board needs a "turnaround" you could just try to see if the lichess username that's logged in is the same as the player in black in the pgn |
Well importing PGN in analysis is meant for external PGN sources, not the lichess PGN. While you can do it, we won't add logic to it. I thought the original issue which made you import lichess PGN in the app was kind of solved now, thus closing the issue. |
My original issue is actually not that My issue doesn't matter where your pgn import from, it's about the part where there is For example if my lichess username matches the username that's in the |
iOS 16.5
iPhone 14
Lichess Beta 0.8.18!
The text was updated successfully, but these errors were encountered: