Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated warnings for some colorSchemes properties #603

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

HaonRekcef
Copy link
Contributor

@HaonRekcef HaonRekcef commented Mar 15, 2024

I fixed the deprecated warnings that appear when running flutter analyze. The background and onBackground were easily replaced with surface and onSurface without any visible changes. The suggested replacement for surfaceVariant did not work; the best I could come up with is tertiary.withOpacity(0.15), and it looks similar to before now.
It changes the color of the tiles with the timecontrols.

I tested it with light, dark, and system colors and different themes, and it looks pretty good.

New Old
Image 1 Image 3
Image 2 Image 4

@veloce veloce merged commit 5d8d02b into lichess-org:main Mar 15, 2024
3 checks passed
@veloce
Copy link
Contributor

veloce commented Mar 15, 2024

Thanks!

@HaonRekcef HaonRekcef deleted the fix-deprecated branch March 15, 2024 20:38
@HaonRekcef HaonRekcef restored the fix-deprecated branch March 17, 2024 19:15
@HaonRekcef HaonRekcef deleted the fix-deprecated branch March 17, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants