Fix Storm Dashboard for Other Users #608
Conversation
|
So you're right we should remove caching to ensure it's always up to date. I'm not sure about player name in title though. Because sometimes it is too long and cannot be displayed entirely. We could maybe show player's name as an intermediate level title in body, only for other players screens. |
|
True, sometimes the name gets cut off. But this also happens for the other stats screen, probably we should fix this on all of them? |
|
Just for the logged in user makes sense yes but normally it is preferable not to cache a provider with parameters to avoid memory leaks, so you can disable it completely. And yes we should also remove user name from perf stats screen title bar. |
|
Okay, I removed the caching. However, I haven't found a good way to position the username somewhere other than in the title bar. Designing isn't exactly my strong suit... 🙃 |
|
Yeah I see that is not obvious to make it look good. Perhaps we can just not display the player's name for now. This screen has to be accessed from the player profile so you'll always know what you're looking at. |
|
I removed the names from the screens, so no more names that are cut off. |
This PR resolves the issue of displaying other users storm highscores. At the moment users would either be directed to their own highscore screen or encounter an error if not logged in.
Now it should correctly display the highscores of other users. Also, I have included the user's name in the screen title, as it's now possible to view highscores of other users.
Preview
One question remaining is whether we really should implement caching for the storm dashboard. Currently, if a user views their history, plays, beats their daily highscore and then revisits their history, the updated highscore isn't displayed.