feat: add setting to enable/disable piece magnification #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-anders
commented
Jul 28, 2024
| @@ -43,4 +43,5 @@ | |||
| <string name="puzzleStormSubtitle" comment="Shown as a description for the 'Puzzle Storm' mode">Solve as many puzzles as possible in 3 minutes.</string> | |||
| <string name="greeting" comment="A greeting that is shown on the app's home page, e.g. 'Hello, GM Magnus'. %s is substituted with the user's name">Hello, %s</string> | |||
| <string name="greetingWithoutName" comment="Greeing that is shown on the app's home page when the user is not logged in.">Hello</string> | |||
| <string name="prefMagnifyDraggedPiece" comment="Title of a setting the settings screen. When enabled, the piece being dragged around the board will be magnified.">Magnify dragged piece</string> | |||
There was a problem hiding this comment.
Note: Since the setting already exists in the old app and is well known, I thought it would be okay to already add a translation.
tom-anders
force-pushed
the
magnificationSetting
branch
from
1fdd8d7
to
bb3d296
Compare
|
Demo: magnify.webm |
tom-anders
commented
Jul 29, 2024
| @@ -506,6 +506,9 @@ class _BoardState extends ConsumerState<_Board> { | |||
| showLastMove: boardPrefs.boardHighlights, | |||
| enableCoordinates: boardPrefs.coordinates, | |||
| animationDuration: boardPrefs.pieceAnimationDuration, | |||
| dragFeedbackSize: boardPrefs.magnifyDraggedPiece ? 2.0 : 1.0, | |||
There was a problem hiding this comment.
Note: This logic is already duplicated (here and in the normal game screen), and once we have the board editor, we'll duplicate it again. Would it make sense to add a method to BoardPreferences that converts BoardPreferences to chessground.ChessBoardSettings and/or chessground.ChessBoardEditorSettings ?
There was a problem hiding this comment.
Done, added BoardPrefs.toBoardSettings()
(also rebased to fix conflicts)
tom-anders
force-pushed
the
magnificationSetting
branch
from
bb3d296
to
2b9336b
Compare
tom-anders
force-pushed
the
magnificationSetting
branch
from
2b9336b
to
b04b8a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #770
Is it worth adding a unit test for this? Or do we rely on chessground behaving correctly here?