refactor: add PlatformScaffold and PlatformAppBar widgets #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-anders
force-pushed
the
platformScaffold
branch
from
6791be1
to
8fbe89d
Compare
We had many screens where there was a lot of code duplication between androidBuilder and iosBuilder when using PlatformWidget. With these two new classes we clean a lot of this up. Custom screens that need to do something different for Android vs iOS still use PlatformWidget.
veloce
reviewed
Sep 2, 2024
| Widget _androidBuilder(BuildContext context) { | ||
| return Scaffold( | ||
| resizeToAvoidBottomInset: resizeToAvoidBottomInset, | ||
| appBar: PreferredSize( |
There was a problem hiding this comment.
Instead of wrapping with PreferredSize, would it be possible to have PlatformAppBar implements ObstructingPreferredSizeWidget and PreferredSizeWidget?
There was a problem hiding this comment.
I thought this was not possible because Android and iOS need different numeric values here, and we can't use Theme.of(context).platform because the context is not available.
veloce
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had many screens where there was a lot of code duplication between androidBuilder and iosBuilder when using PlatformWidget. With these two new classes we clean a lot of this up.
Custom screens that need to do something different for Android vs iOS still use PlatformWidget.
This may be a bit more controversial than #938, and I'm totally fine if you don't want to merge this, I had a lot of fun refactoring and learned a lot anyway. I think this change would improve readability of the code base, especially for new contributors.
If you agree, I can again make some screenshots, confirming that everything still looks as before (I can only test Android though, not iOS)