Mellow mvp #224
Merged
Mellow mvp #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F4ever
reviewed
Jun 25, 2024
F4ever
reviewed
Jun 26, 2024
F4ever
reviewed
Jun 27, 2024
F4ever
reviewed
Jun 27, 2024
F4ever
reviewed
Jun 27, 2024
F4ever
reviewed
Jun 27, 2024
F4ever
reviewed
Jun 27, 2024
F4ever
reviewed
Jun 27, 2024
Co-authored-by: Raman Siamionau <raman.s@lido.fi>
F4ever
reviewed
Jun 28, 2024
F4ever
reviewed
Jun 28, 2024
F4ever
reviewed
Jun 28, 2024
F4ever
reviewed
Jun 28, 2024
F4ever
reviewed
Jul 1, 2024
Co-authored-by: Raman Siamionau <raman.s@lido.fi>
F4ever
reviewed
Jul 2, 2024
F4ever
reviewed
Jul 2, 2024
F4ever
approved these changes
Jul 2, 2024
F4ever
approved these changes
Jul 2, 2024
infloop
approved these changes
Jul 2, 2024
hweawer
added a commit
that referenced
this pull request
Aug 5, 2024
* chore: set default strategy * Upgrade python to 3.12 * Upgrade poetry * upgrade curl * Mellow mvp (#224) * Mellow direct deposit, skip ABI * Prepare direct deposit transaction * Property checking * Fix linter * amount parameter in the contract * Fix comments * Check variable not set * Contract abi integration test * Add fixtures * Remove amount parameter from abi * Formatter changes * Formatter changes * Holesky mark in tests * Test balanceOf of weth * Renamings * Rename mark * block_identifier * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix comments * Renamed env var in pipeline * Change module to deposit * Send mellow transaction * Change comment * DD description * Update README.md Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor sending mellow transaction * Refactor sending mellow transaction * is_mellow_depositable unit test * Unit test for sending mellow tx * Formatting --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric for modules (#229) * Expose modules metric * Reorder * Reorder * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Log env vars (#227) * Log public env vars * Add chain_id * Public env vars in prometheus metric * Add message to a log * Change info description * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Remove prefix, not assert * Fix imports --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix Info metircs endpoint(#231) * Fix log string * Change forematting * Convert values to strings * remove convertion * Mellow deposit strategy (#230) * Change validation for mellow deposits * Load WQ contract from the locator * Refactor * Change log message * Beffered ether * Change ABI * Move check inside is_mellow_depositable * Add ping type to the rabbit messages in the unvetter * Mellow new ABIs * Remove old build metrics (#239) * Add mellow variable to examples (#237) * Add mellow variable to examples * Remove import * Update holesky address * Add account to variables (#241) * Add account to metrics * Fix field ref * Change to propery * Direct access property * Separate mellow flow (#235) * Separate mellow flow * Formatting * Rerun integration tests * Strategy return * Rewrite to abstract classes * Fix formatting * Fix bug with return * Restructure * remove init * _is_mellow * Fix tests * Fix signs test * Fix integration * Fix unit test * Mellow test * Update src/blockchain/deposit_strategy/base_deposit_strategy.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor * Renamings * Imports * inject dependecies --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric per module (#244) * Per module metric * FOrmatting * Fix error repr --------- Co-authored-by: F4ever <raman.s@lido.fi>
hweawer
added a commit
that referenced
this pull request
Aug 12, 2024
* chore: set default strategy * Upgrade python to 3.12 * Upgrade poetry * upgrade curl * Mellow mvp (#224) * Mellow direct deposit, skip ABI * Prepare direct deposit transaction * Property checking * Fix linter * amount parameter in the contract * Fix comments * Check variable not set * Contract abi integration test * Add fixtures * Remove amount parameter from abi * Formatter changes * Formatter changes * Holesky mark in tests * Test balanceOf of weth * Renamings * Rename mark * block_identifier * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix comments * Renamed env var in pipeline * Change module to deposit * Send mellow transaction * Change comment * DD description * Update README.md Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor sending mellow transaction * Refactor sending mellow transaction * is_mellow_depositable unit test * Unit test for sending mellow tx * Formatting --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric for modules (#229) * Expose modules metric * Reorder * Reorder * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Log env vars (#227) * Log public env vars * Add chain_id * Public env vars in prometheus metric * Add message to a log * Change info description * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Remove prefix, not assert * Fix imports --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix Info metircs endpoint(#231) * Fix log string * Change forematting * Convert values to strings * remove convertion * Mellow deposit strategy (#230) * Change validation for mellow deposits * Load WQ contract from the locator * Refactor * Change log message * Beffered ether * Change ABI * Move check inside is_mellow_depositable * Add ping type to the rabbit messages in the unvetter * Mellow new ABIs * Remove old build metrics (#239) * Add mellow variable to examples (#237) * Add mellow variable to examples * Remove import * Update holesky address * Add account to variables (#241) * Add account to metrics * Fix field ref * Change to propery * Direct access property * Separate mellow flow (#235) * Separate mellow flow * Formatting * Rerun integration tests * Strategy return * Rewrite to abstract classes * Fix formatting * Fix bug with return * Restructure * remove init * _is_mellow * Fix tests * Fix signs test * Fix integration * Fix unit test * Mellow test * Update src/blockchain/deposit_strategy/base_deposit_strategy.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor * Renamings * Imports * inject dependecies --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric per module (#244) * Per module metric * FOrmatting * Fix error repr * Metrics for checks (#246) * Metrics for different check statuses * Formatting * Fix early returns (#248) * Mellow fallback (#250) * Mellow fallback * Fix unit tests * Fix DepositorBot constructor in test * Fix positional argument * Double max deposit count * Fix test * Improve test * Sender chain in integrations * Without sender chain * Reorder * Remove redundant function * New metric for mellow * Cast * Merge main --------- Co-authored-by: F4ever <raman.s@lido.fi>
hweawer
added a commit
that referenced
this pull request
Aug 12, 2024
) * Upgrade curl * Mellow integration (#247) * chore: set default strategy * Upgrade python to 3.12 * Upgrade poetry * upgrade curl * Mellow mvp (#224) * Mellow direct deposit, skip ABI * Prepare direct deposit transaction * Property checking * Fix linter * amount parameter in the contract * Fix comments * Check variable not set * Contract abi integration test * Add fixtures * Remove amount parameter from abi * Formatter changes * Formatter changes * Holesky mark in tests * Test balanceOf of weth * Renamings * Rename mark * block_identifier * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix comments * Renamed env var in pipeline * Change module to deposit * Send mellow transaction * Change comment * DD description * Update README.md Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor sending mellow transaction * Refactor sending mellow transaction * is_mellow_depositable unit test * Unit test for sending mellow tx * Formatting --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric for modules (#229) * Expose modules metric * Reorder * Reorder * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Log env vars (#227) * Log public env vars * Add chain_id * Public env vars in prometheus metric * Add message to a log * Change info description * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Remove prefix, not assert * Fix imports --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix Info metircs endpoint(#231) * Fix log string * Change forematting * Convert values to strings * remove convertion * Mellow deposit strategy (#230) * Change validation for mellow deposits * Load WQ contract from the locator * Refactor * Change log message * Beffered ether * Change ABI * Move check inside is_mellow_depositable * Add ping type to the rabbit messages in the unvetter * Mellow new ABIs * Remove old build metrics (#239) * Add mellow variable to examples (#237) * Add mellow variable to examples * Remove import * Update holesky address * Add account to variables (#241) * Add account to metrics * Fix field ref * Change to propery * Direct access property * Separate mellow flow (#235) * Separate mellow flow * Formatting * Rerun integration tests * Strategy return * Rewrite to abstract classes * Fix formatting * Fix bug with return * Restructure * remove init * _is_mellow * Fix tests * Fix signs test * Fix integration * Fix unit test * Mellow test * Update src/blockchain/deposit_strategy/base_deposit_strategy.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor * Renamings * Imports * inject dependecies --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric per module (#244) * Per module metric * FOrmatting * Fix error repr --------- Co-authored-by: F4ever <raman.s@lido.fi> * Release mellow main (#254) * chore: set default strategy * Upgrade python to 3.12 * Upgrade poetry * upgrade curl * Mellow mvp (#224) * Mellow direct deposit, skip ABI * Prepare direct deposit transaction * Property checking * Fix linter * amount parameter in the contract * Fix comments * Check variable not set * Contract abi integration test * Add fixtures * Remove amount parameter from abi * Formatter changes * Formatter changes * Holesky mark in tests * Test balanceOf of weth * Renamings * Rename mark * block_identifier * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix comments * Renamed env var in pipeline * Change module to deposit * Send mellow transaction * Change comment * DD description * Update README.md Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor sending mellow transaction * Refactor sending mellow transaction * is_mellow_depositable unit test * Unit test for sending mellow tx * Formatting --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric for modules (#229) * Expose modules metric * Reorder * Reorder * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Log env vars (#227) * Log public env vars * Add chain_id * Public env vars in prometheus metric * Add message to a log * Change info description * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Remove prefix, not assert * Fix imports --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix Info metircs endpoint(#231) * Fix log string * Change forematting * Convert values to strings * remove convertion * Mellow deposit strategy (#230) * Change validation for mellow deposits * Load WQ contract from the locator * Refactor * Change log message * Beffered ether * Change ABI * Move check inside is_mellow_depositable * Add ping type to the rabbit messages in the unvetter * Mellow new ABIs * Remove old build metrics (#239) * Add mellow variable to examples (#237) * Add mellow variable to examples * Remove import * Update holesky address * Add account to variables (#241) * Add account to metrics * Fix field ref * Change to propery * Direct access property * Separate mellow flow (#235) * Separate mellow flow * Formatting * Rerun integration tests * Strategy return * Rewrite to abstract classes * Fix formatting * Fix bug with return * Restructure * remove init * _is_mellow * Fix tests * Fix signs test * Fix integration * Fix unit test * Mellow test * Update src/blockchain/deposit_strategy/base_deposit_strategy.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor * Renamings * Imports * inject dependecies --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric per module (#244) * Per module metric * FOrmatting * Fix error repr * Metrics for checks (#246) * Metrics for different check statuses * Formatting * Fix early returns (#248) * Mellow fallback (#250) * Mellow fallback * Fix unit tests * Fix DepositorBot constructor in test * Fix positional argument * Double max deposit count * Fix test * Improve test * Sender chain in integrations * Without sender chain * Reorder * Remove redundant function * New metric for mellow * Cast * Merge main --------- Co-authored-by: F4ever <raman.s@lido.fi> * If the mellow strategy is failing fallback to the default strategy --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi>
hweawer
added a commit
that referenced
this pull request
Aug 12, 2024
* Mellow direct deposit, skip ABI * Prepare direct deposit transaction * Property checking * Fix linter * amount parameter in the contract * Fix comments * Check variable not set * Contract abi integration test * Add fixtures * Remove amount parameter from abi * Formatter changes * Formatter changes * Holesky mark in tests * Test balanceOf of weth * Renamings * Rename mark * block_identifier * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix comments * Renamed env var in pipeline * Change module to deposit * Send mellow transaction * Change comment * DD description * Update README.md Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor sending mellow transaction * Refactor sending mellow transaction * is_mellow_depositable unit test * Unit test for sending mellow tx * Formatting --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi>
hweawer
added a commit
that referenced
this pull request
Aug 12, 2024
) * Upgrade curl * Mellow integration (#247) * chore: set default strategy * Upgrade python to 3.12 * Upgrade poetry * upgrade curl * Mellow mvp (#224) * Mellow direct deposit, skip ABI * Prepare direct deposit transaction * Property checking * Fix linter * amount parameter in the contract * Fix comments * Check variable not set * Contract abi integration test * Add fixtures * Remove amount parameter from abi * Formatter changes * Formatter changes * Holesky mark in tests * Test balanceOf of weth * Renamings * Rename mark * block_identifier * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix comments * Renamed env var in pipeline * Change module to deposit * Send mellow transaction * Change comment * DD description * Update README.md Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor sending mellow transaction * Refactor sending mellow transaction * is_mellow_depositable unit test * Unit test for sending mellow tx * Formatting --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric for modules (#229) * Expose modules metric * Reorder * Reorder * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Log env vars (#227) * Log public env vars * Add chain_id * Public env vars in prometheus metric * Add message to a log * Change info description * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Remove prefix, not assert * Fix imports --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix Info metircs endpoint(#231) * Fix log string * Change forematting * Convert values to strings * remove convertion * Mellow deposit strategy (#230) * Change validation for mellow deposits * Load WQ contract from the locator * Refactor * Change log message * Beffered ether * Change ABI * Move check inside is_mellow_depositable * Add ping type to the rabbit messages in the unvetter * Mellow new ABIs * Remove old build metrics (#239) * Add mellow variable to examples (#237) * Add mellow variable to examples * Remove import * Update holesky address * Add account to variables (#241) * Add account to metrics * Fix field ref * Change to propery * Direct access property * Separate mellow flow (#235) * Separate mellow flow * Formatting * Rerun integration tests * Strategy return * Rewrite to abstract classes * Fix formatting * Fix bug with return * Restructure * remove init * _is_mellow * Fix tests * Fix signs test * Fix integration * Fix unit test * Mellow test * Update src/blockchain/deposit_strategy/base_deposit_strategy.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor * Renamings * Imports * inject dependecies --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric per module (#244) * Per module metric * FOrmatting * Fix error repr --------- Co-authored-by: F4ever <raman.s@lido.fi> * Release mellow main (#254) * chore: set default strategy * Upgrade python to 3.12 * Upgrade poetry * upgrade curl * Mellow mvp (#224) * Mellow direct deposit, skip ABI * Prepare direct deposit transaction * Property checking * Fix linter * amount parameter in the contract * Fix comments * Check variable not set * Contract abi integration test * Add fixtures * Remove amount parameter from abi * Formatter changes * Formatter changes * Holesky mark in tests * Test balanceOf of weth * Renamings * Rename mark * block_identifier * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix comments * Renamed env var in pipeline * Change module to deposit * Send mellow transaction * Change comment * DD description * Update README.md Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor sending mellow transaction * Refactor sending mellow transaction * is_mellow_depositable unit test * Unit test for sending mellow tx * Formatting --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric for modules (#229) * Expose modules metric * Reorder * Reorder * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Log env vars (#227) * Log public env vars * Add chain_id * Public env vars in prometheus metric * Add message to a log * Change info description * Update src/variables.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Update src/metrics/metrics.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Remove prefix, not assert * Fix imports --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Fix Info metircs endpoint(#231) * Fix log string * Change forematting * Convert values to strings * remove convertion * Mellow deposit strategy (#230) * Change validation for mellow deposits * Load WQ contract from the locator * Refactor * Change log message * Beffered ether * Change ABI * Move check inside is_mellow_depositable * Add ping type to the rabbit messages in the unvetter * Mellow new ABIs * Remove old build metrics (#239) * Add mellow variable to examples (#237) * Add mellow variable to examples * Remove import * Update holesky address * Add account to variables (#241) * Add account to metrics * Fix field ref * Change to propery * Direct access property * Separate mellow flow (#235) * Separate mellow flow * Formatting * Rerun integration tests * Strategy return * Rewrite to abstract classes * Fix formatting * Fix bug with return * Restructure * remove init * _is_mellow * Fix tests * Fix signs test * Fix integration * Fix unit test * Mellow test * Update src/blockchain/deposit_strategy/base_deposit_strategy.py Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Refactor * Renamings * Imports * inject dependecies --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi> * Metric per module (#244) * Per module metric * FOrmatting * Fix error repr * Metrics for checks (#246) * Metrics for different check statuses * Formatting * Fix early returns (#248) * Mellow fallback (#250) * Mellow fallback * Fix unit tests * Fix DepositorBot constructor in test * Fix positional argument * Double max deposit count * Fix test * Improve test * Sender chain in integrations * Without sender chain * Reorder * Remove redundant function * New metric for mellow * Cast * Merge main --------- Co-authored-by: F4ever <raman.s@lido.fi> * If the mellow strategy is failing fallback to the default strategy --------- Co-authored-by: Raman Siamionau <raman.s@lido.fi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.