-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add recursive dependency search for imported contracts #25
feat: add recursive dependency search for imported contracts #25
Conversation
Thank you for proposing this change 🙏 Let me shed a bit of light here 🤔 I suggest NOT enabling recursive ('fuzzy') search by default but instead utilizing it only if the enforcement flag is provided within the config. Also, the flag might be omitted to preserve backward compatibility, falling back to the previous (strict search) behavior. wdyt, @rkolpakov and @mymphe? |
I'd prefer it enabled by flag (NOT default) as well. Although I cannot come up with an example when enabling this by default would lead to a bad outcome, I'd like to see more strictness in such a bedrock tool. |
Agree with @arwer13. I think this feature is only useful for certain scenarios and should be explicitly enabled. Overall, a tool such as Diffyscan should be as dumb as possible, imo. Making it too smart might lead to critical false positives. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the code and fixes! Almost there from my point of view, left just a pair of minor doc-related comments.
3ea2f18
to
f761f76
Compare
Added possibility to verify contracts if they have dependencies. Used a recursive search over the repo on github to cover complex contracts e.g. EasyTrack.