Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make installable via poetry / pipx #47

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

madlabman
Copy link
Contributor

No description provided.

Copy link
Contributor

@mymphe mymphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature!

Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great proposal!

I'd suggest addressing only a single suggestion regarding the version bookkeeping approach to make it more robust.

pyproject.toml Outdated Show resolved Hide resolved
@madlabman madlabman requested review from TheDZhon and mymphe June 3, 2024 14:32
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, merging to the upstream 👍

@TheDZhon TheDZhon merged commit da194e4 into lidofinance:main Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants