Feat: integration tests for contracts #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F4ever
changed the base branch from
feat/oracle-v4
to
feat/abstract-contract-interaction
vgorkavenko
reviewed
May 28, 2024
.github/workflows/tests.yml
Outdated
| run: poetry run pytest -m "not integration and not e2e" --cov=src tests | ||
| run: poetry run pytest --cov=src tests | ||
| env: | ||
| LIDO_LOCATOR_ADDRESS: 0xC1d0b3DE6792Bf6b4b37EccdcC24e45978Cfd2Eb |
There was a problem hiding this comment.
why you need real locator address for unit tests?
There was a problem hiding this comment.
Now there are some integration tests, but placed this constant inside, because tests are bind to mainnet currently
| @@ -104,8 +104,8 @@ class SharesRequestedToBurn: | |||
|
|
|||
| @dataclass | |||
| class WithdrawalRequestStatus: | |||
| amountOfStETH: int | |||
| amountOfShares: int | |||
| amount_of_st_eth: int | |||
There was a problem hiding this comment.
Suggested change
| amount_of_st_eth: int | |
| amount_of_steth: int |
There was a problem hiding this comment.
named_tuple_to_dataclass automatically renames amountOfStETH to amount_of_st_eth. Don't think we need any exceptions for this case
madlabman
reviewed
May 29, 2024
F4ever
changed the base branch from
feat/abstract-contract-interaction
to
feat/oracle-v4
…ido-oracle into feat/tests-for-abstraction
vgorkavenko
approved these changes
May 30, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.