Feat: VEBO v4 upgrade #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F4ever
changed the base branch from
feat/oracle-v4
to
feat/base-oracle-versioning
F4ever
changed the base branch from
feat/base-oracle-versioning
to
feat/tests-for-abstraction
vgorkavenko
reviewed
Jun 6, 2024
src/modules/ejector/ejector.py
Outdated
| if consensus_version != 1: | ||
| forced_validators = validators_iterator.get_remaining_forced_validators() | ||
| if forced_validators: | ||
| logger.info({'msg': 'Eject delayed forced to exit validators.', 'value': len(forced_validators)}) |
There was a problem hiding this comment.
msg is not clear for me
Comment on lines
-184
to
-185
| (_, validator) = validator_container | ||
| validator_to_eject_balance_sum += self._get_predicted_withdrawable_balance(validator) |
| raise StopIteration | ||
|
|
||
| for node_operator in sorted(self.node_operators_stats.values(), key=self._no_predicate): | ||
| if node_operator.exitable_validators: |
There was a problem hiding this comment.
Suggested change
| if node_operator.exitable_validators: | |
| if not node_operator.exitable_validators: | |
| break |
There was a problem hiding this comment.
Would be great to have the same as tests/modules/ejector/test_exit_order_iterator.py tests here to make sure that the new version works as the old one in the same cases
madlabman
reviewed
Jun 10, 2024
| @@ -100,9 +100,11 @@ def get_web3_provider_map(cls): | |||
| faker = cls.get_faker() | |||
|
|
|||
| return { | |||
| str: faker.pyint, | |||
There was a problem hiding this comment.
Lifehack to not rewrite a lot of tests
That's because all CL responses are str =(
But for example, "index" should be int.
madlabman
approved these changes
Jun 11, 2024
F4ever
changed the base branch from
feat/tests-for-abstraction
to
feat/oracle-v4
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.