New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zk-atoms actually persist #16

Merged
merged 1 commit into from Jun 30, 2014

Conversation

Projects
None yet
2 participants
@holguinj
Contributor

holguinj commented Jun 30, 2014

I spoke too soon before when I said this wasn't an issue. It turns out
that zk-atoms would persist as long as some client was
connected, but otherwise they would disappear. Weirdly, this isn't a
problem with zk-refs.

This commit changes the way that zk-atoms are created in ZooKeeper by
adding :persistent? true.

Make zk-atoms actually persist
I spoke too soon before when I said this wasn't an issue. It turns out
that zk-atoms would persist as long as _some_ client was
connected, but otherwise they would disappear. Weirdly, this isn't a
problem with zk-refs.

This commit changes the way that zk-atoms are created in ZooKeeper by
adding `:persistent? true`.

@holguinj holguinj referenced this pull request Jun 30, 2014

Closed

zk-atoms do not persist #2

@@ -9,7 +9,7 @@
StateContainer
(initStateContainer [this]
(zk/create-all (.getClient client-handle) dataNode))
(zk/create-all (.getClient client-handle) dataNode :persistent? true))

This comment has been minimized.

@holguinj

holguinj Jun 30, 2014

Contributor

Note that the dataNode (a child of the atom's node) was not being created with :persistent? true, even though the atom node was. In practice, that meant that atoms would persist, but their values would not.

@holguinj

holguinj Jun 30, 2014

Contributor

Note that the dataNode (a child of the atom's node) was not being created with :persistent? true, even though the atom node was. In practice, that meant that atoms would persist, but their values would not.

liebke added a commit that referenced this pull request Jun 30, 2014

Merge pull request #16 from holguinj/issue-2
Make zk-atoms actually persist

@liebke liebke merged commit 06f3e00 into liebke:master Jun 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment