Make zk-atoms actually persist #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spoke too soon before when I said this wasn't an issue. It turns out that zk-atoms would persist as long as _some_ client was connected, but otherwise they would disappear. Weirdly, this isn't a problem with zk-refs. This commit changes the way that zk-atoms are created in ZooKeeper by adding `:persistent? true`.
Closed
| @@ -9,7 +9,7 @@ | |||
| StateContainer | |||
|
|
|||
| (initStateContainer [this] | |||
| (zk/create-all (.getClient client-handle) dataNode)) | |||
| (zk/create-all (.getClient client-handle) dataNode :persistent? true)) | |||
There was a problem hiding this comment.
Note that the dataNode (a child of the atom's node) was not being created with :persistent? true, even though the atom node was. In practice, that meant that atoms would persist, but their values would not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spoke too soon before when I said this wasn't an issue. It turns out
that zk-atoms would persist as long as some client was
connected, but otherwise they would disappear. Weirdly, this isn't a
problem with zk-refs.
This commit changes the way that zk-atoms are created in ZooKeeper by
adding
:persistent? true.