Utilize SH_LINK section metadata to resolve relocation's target symbol table #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't add any tests here - for the bugfix, is it possible to add the binary from my issue to the set of binaries downloaded by |
romainthomas
force-pushed
the
reloc-symbol-table
branch
from
943cf94
to
bf7f36b
Compare
|
Thank you @adamjseitz! I updated the PR to include the tests.
They are actually hosted on my computer that I sync on the url: data.romainthomas.fr/lief_tests.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symbol_tableAPI to theLIEF::ELF::RelocationclassSH_LINKandSH_INFOattributes in the ELFparse_section_relocationsfunction; according to Figure 4-12 in https://refspecs.linuxbase.org/elf/gabi4+/ch4.sheader.html#sh_link, these are identified in the expected way.