Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Markdown files using guide layout does not support ordered and unordered entries in the same list #36

Closed
anthony-chu opened this issue Mar 10, 2017 · 7 comments

Comments

@anthony-chu
Copy link
Member

When adding a markdown page using the guide layout, lists that have both ordered and unordered list items don't render properly.

1. Numbered item 1
    - child item 1
1. Numbered item 2

should render as

  1. Numbered item 1
    • child item 1
  2. Numbered item 2

but instead renders as

1. Numbered item 1
    - child item 1
3. Numbered item 2

the next numbered list item should be 2, but instead a 3 is displayed, as it appears to be counting the "-" as another ordered item (even though there's an indentation that denotes otherwise).

@zenorocha
Copy link
Contributor

Sounds like a problem related to Soy rendering, can you check @Robert-Frampton?

@robframpton
Copy link

Hey @anthony-chu

Can you provide entire markdown file for context?

@anthony-chu
Copy link
Member Author

hey @Robert-Frampton, I made it a gist here.

@robframpton
Copy link

Looks like the nested list elements were just indented too much (each had 8 spaces). If you indent the nested lists with a tab, or with 4 spaces it'll work.

screen shot 2017-03-13 at 3 41 44 pm

@robframpton
Copy link

Hey @anthony-chu @zenorocha

I found the root cause of the issue, the generated markup is actually fine, Marble is actually what's causing the issue with the ordered lists not displaying the correct number.

Normally the browser displays the number, but for whatever reason Marble hides it and does some custom styling and uses the :before content of of the list item to display it.

@zenorocha
Copy link
Contributor

Nice! @ygorcosta can you take a look?

@ygorcosta
Copy link
Contributor

hey @zenorocha, I've fixed that on marble v2.9.6

@anthony-chu can you update your marble version and test?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants