Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for LPS-30666 : Problem in Session Sharing between Portlet and Servlet when name of the variable starts with shared session attribute keyword. #281

Closed
wants to merge 1 commit into from

Conversation

sushilsaini
Copy link

Hi there,

I have found a bug in a liferay and implemented the solution also. Please review the solution and if you find it suitable. please include it into the liferay source code.

Brief Description: Problem in Session Sharing between Portlet and Servlet when name of the variable starts with shared session attribute keyword.

For seeing the complete detail of the problem, please see the corresponding jira ticket and forum post.

Jira Ticket : http://issues.liferay.com/browse/LPS-30666
Forum Post : http://www.liferay.com/community/forums/-/message_boards/message/17448574

Please let me know if you want any more details from me.

Thanks & Regards
Sushil Saini

…en name of the variable starts with same shared session attribute keyword.
@JorgeFerrer
Copy link
Contributor

Already committed: http://issues.liferay.com/browse/LPS-30666

@sushilsaini
Copy link
Author

Hi Jorge, .... What do you mean by "Already committed"... Has this change already been incorporated?

@JorgeFerrer
Copy link
Contributor

It seems so. See http://issues.liferay.com/browse/LPS-30666 for details.

@sushilsaini
Copy link
Author

Hi Jorge,... I created that Jira ticket(LPS-30666) and also submit this code fix for same issue.... As per my understanding this code has not been merged with the main liferay trunk ....... But I think this fix should be incorporated........ because this particular scenario of session sharing was working fine in earlier version of liferay and just got broken in liferay version 6.1.1 ..... please let me know if you want more details.

@JorgeFerrer
Copy link
Contributor

Looking at the ticket in more detail it seems that Tomas dismissed this as a bug, since it was only working previously as a side effect of a bug, not as an intended feature. If you disagree it might be better for you to discuss it in the JIRA ticket.

@sushilsaini
Copy link
Author

Thanks Jorge,...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants