-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-110422 Gradle plugins not compatible with gradle 6.0+ #3742
Conversation
* Add OsgiHelper in gradle-util * Replace gradle osgi plugin dependency by local OsgiHelper
Is there any reason why this should not be merged ? |
In practice, pulls need to go to be sent to brianchandotcom's fork, not this one. (He merges the commits to his fork, and that |
@wincent, I've create a jira account to create a bug, I have done my best to contribute. And no feedback since... |
Sorry to hear about your experience, @damien-abos. FWIW, we're already aware of some of the barriers to contributing, but it's still useful to hear feedback like this. (And I'll mention @JorgeFerrer, Liferay's VP of Engineering, here, because I know this is a subject that he has been monitoring.) |
Hey @damien-abos , I'm really sorry that you've had such a bad experience trying to contribute. We are aware that we need to continue investing in improving it. |
@petershin could you please take a look at this PR? |
@dgomezg - Forwarded the pull to review the changes petershin#984 |
@JorgeFerrer for what its worth as much as you can keep everything in Github the easier it will be for people to contribute, Pull Requests at least and issues would be even better. |
Thanks Judd, we agree. |
for Gradle 6 compatibility