Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-110422 Gradle plugins not compatible with gradle 6.0+ #3742

Closed
wants to merge 1 commit into from

Conversation

damien-abos
Copy link
Contributor

for Gradle 6 compatibility

@damien-abos damien-abos changed the title fix gradle osgi plugin dependency Gradle plugins not compatible with gradle 6.0+ Mar 16, 2020
@damien-abos damien-abos changed the title Gradle plugins not compatible with gradle 6.0+ LPS-110422 - Gradle plugins not compatible with gradle 6.0+ Mar 16, 2020
@damien-abos damien-abos changed the title LPS-110422 - Gradle plugins not compatible with gradle 6.0+ LPS-110422 Gradle plugins not compatible with gradle 6.0+ Mar 16, 2020
* Add OsgiHelper in gradle-util
* Replace gradle osgi plugin dependency by local OsgiHelper
@juddgaddie
Copy link

Is there any reason why this should not be merged ?

@wincent
Copy link
Contributor

wincent commented Apr 24, 2020

Is there any reason why this should not be merged ?

In practice, pulls need to go to be sent to brianchandotcom's fork, not this one. (He merges the commits to his fork, and that master branch gets periodically, automatically synced over here).

@damien-abos
Copy link
Contributor Author

@wincent, I've create a jira account to create a bug, I have done my best to contribute. And no feedback since...
There is no clear process in liferay community : it's a shame !

@wincent
Copy link
Contributor

wincent commented Apr 24, 2020

@wincent, I've create a jira account to create a bug, I have done my best to contribute. And no feedback since...
There is no clear process in liferay community : it's a shame !

Sorry to hear about your experience, @damien-abos. FWIW, we're already aware of some of the barriers to contributing, but it's still useful to hear feedback like this. (And I'll mention @JorgeFerrer, Liferay's VP of Engineering, here, because I know this is a subject that he has been monitoring.)

@JorgeFerrer
Copy link
Contributor

Hey @damien-abos ,

I'm really sorry that you've had such a bad experience trying to contribute. We are aware that we need to continue investing in improving it.
The process itself is documented at https://portal.liferay.dev/participate/feedback/overview and in particular here: https://portal.liferay.dev/participate/fix-a-bug/overview
As you can see, you have actually done the right thing sending the pull here. We have recently had some changes in the team responsible for monitoring these pulls and it seems your (and possibly some others) have not been noticed. I'll bring it up to them.
Please keep the contributions coming and feel free to mention me directly when you don't hear back after a reasonable period.

@dgomezg
Copy link
Contributor

dgomezg commented Apr 27, 2020

@petershin could you please take a look at this PR?

@petershin
Copy link
Member

@dgomezg - Forwarded the pull to review the changes petershin#984

@petershin petershin closed this Apr 27, 2020
@juddgaddie
Copy link

@JorgeFerrer for what its worth as much as you can keep everything in Github the easier it will be for people to contribute, Pull Requests at least and issues would be even better.

@JorgeFerrer
Copy link
Contributor

Thanks Judd, we agree.
We've evaluated Github issues but we use too many JIRA features that are not supported there (yet).
However, we decided to not mandate having a JIRA issue to send a pull request, which should reduce the burden, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants