LPD-29337 Resolve test failures in DatabaseUpgradeClient #5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci:test:upgrade |
|
@javalosjr96 please send it to database-infra repo to be tested |
achaparro
reviewed
Jul 4, 2024
| @@ -119,7 +119,7 @@ definition { | |||
|
|
|||
| var schemaVersion = ValidateSmokeUpgrade.getSchemaVersion(mysqlStatement = "SELECT schemaVersion FROM Release_ WHERE servletContextName = 'com.liferay.journal.web';"); | |||
|
|
|||
| if (!(contains(${schemaVersion}, "0.0.1"))) { | |||
| if (!(contains(${schemaVersion}, "4.1.0"))) { | |||
There was a problem hiding this comment.
@javalosjr96 from which module you got the 4.1.0 version? In this case we are queryin the journal web module, see JournalWebUpgradeStepRegistrator
achaparro
reviewed
Jul 4, 2024
| if (!_verifyProcessError && | ||
| message.contains(VerifyException.class.getName())) { | ||
|
|
||
| if (!_verifyProcessError && loggerName.contains("verify")) { |
There was a problem hiding this comment.
@javalosjr96 checking just the verify string is weak, why is this needed?
|
@javalosjr96 I have sent a new PR: |
|
ci:close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.