fix: json assertions #267
Merged
fix: json assertions #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNR500
commented
Jul 9, 2024
| @@ -1,7 +1,8 @@ | |||
| import type { LiFiStepExtended } from '@lifi/sdk'; | |||
| import { useEffect, useState } from 'react'; | |||
| import { useTranslation } from 'react-i18next'; | |||
| import { useTimer } from 'react-timer-hook'; | |||
| import pkg from 'react-timer-hook'; | |||
There was a problem hiding this comment.
added this as there was an error from one of the examples about this package being common js
DNR500
commented
Jul 9, 2024
| @@ -25,8 +25,7 @@ export function WalletHeader() { | |||
| <Button | |||
| variant="contained" | |||
| disableElevation | |||
| // onClick={handleDisconnect} | |||
| onClick={() => connectAsync({ connector: connectors[0] })} | |||
| onClick={() => connectAsync({ connector: connectors[1] })} | |||
There was a problem hiding this comment.
This wasn't work - this fix at least allow a user to connect using WalletConnect dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: LF-9087
We were have some issues in some of the dev tools that we support related to json assertions.
We had originally tried to put json assertions in place but reverted the change as it caused problems with the use of Create React App.
In regards to this, this PR..
nextjs(next v14) andnextjs-page-router(next v13) examples to document best usage in Pages and App routerremixexamplein addition..
Though this change also helps improve the usage of the WidgetSkeleton there are still some issues relating to its usage - these might be best explored in future tickets.
nextjs-page-routerexample)Testing
I've tested the Widget updates locally using the examples.
Release considerations