-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/update eslint rules and fix tests #518
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #518 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 1398 1398
Branches 190 190
=========================================
Hits 1398 1398
Continue to review full report at Codecov.
|
Node v16 seems to introduce heap out of memory issues with jest, particularly for tests in |
Node engine version is now fixed at >17.0.1 and 16.9.1<=14.0.0. Due to an error introduced in 16.10.0, where arrays are not allowed in stream pipeline promises. This causes the retry loop to restart during the tests, which causes the heap out of memory error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments. Please send me the ticket once you create it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good. Lets just insure that its not going to be used outside available versions. (see comment below)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🎉
@eaviles Please review
New Dependency fixes for: 7739629