Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/update eslint rules and fix tests #518

Merged
merged 10 commits into from
Dec 13, 2021

Conversation

alo3y
Copy link
Collaborator

@alo3y alo3y commented Nov 1, 2021

New Dependency fixes for: 7739629

  • Updates eslint rules based on new dependency bumps.
  • Fixes tests based on jest v27 bump.

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #518 (da10c36) into develop (039d479) will not change coverage.
The diff coverage is n/a.

❗ Current head da10c36 differs from pull request most recent head b645d86. Consider uploading reports for the commit b645d86 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines         1398      1398           
  Branches       190       190           
=========================================
  Hits          1398      1398           
Impacted Files Coverage Δ
lib/dynamodb-client.js 100.00% <ø> (ø)
lib/s3-client.js 100.00% <ø> (ø)
lib/index.js 100.00% <0.00%> (ø)
lib/fan-out-consumer.js 100.00% <0.00%> (ø)
lib/polling-consumer.js 100.00% <0.00%> (ø)
lib/consumers-manager.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7739629...b645d86. Read the comment docs.

@alo3y
Copy link
Collaborator Author

alo3y commented Nov 1, 2021

Node v16 seems to introduce heap out of memory issues with jest, particularly for tests in fan-out-consumer.test.js. It seems to be triggered because of calling the start() function, the first 3 tests which does not call consumer.start(), does not have memory issues.

@alo3y
Copy link
Collaborator Author

alo3y commented Nov 5, 2021

Node engine version is now fixed at >17.0.1 and 16.9.1<=14.0.0. Due to an error introduced in 16.10.0, where arrays are not allowed in stream pipeline promises. This causes the retry loop to restart during the tests, which causes the heap out of memory error.

Copy link
Contributor

@jennyEckstein jennyEckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments. Please send me the ticket once you create it.

.eslintrc Outdated Show resolved Hide resolved
.github/workflows/pull-request-check.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@jennyEckstein jennyEckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Lets just insure that its not going to be used outside available versions. (see comment below)

package.json Show resolved Hide resolved
jennyEckstein
jennyEckstein previously approved these changes Nov 17, 2021
Copy link
Contributor

@jennyEckstein jennyEckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉
@eaviles Please review

.eslintrc Outdated Show resolved Hide resolved
.npmrc Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
jennyEckstein
jennyEckstein previously approved these changes Nov 22, 2021
eaviles
eaviles previously approved these changes Dec 13, 2021
@alo3y alo3y dismissed stale reviews from eaviles and jennyEckstein via b645d86 December 13, 2021 19:03
@eaviles eaviles merged commit 6fb394b into develop Dec 13, 2021
@eaviles eaviles deleted the bugfix/update-eslint-rules-and-fix-tests branch December 13, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants