Renaming the Position.scala file to ScalaPosition.scala to avoid #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name conflicts with the private class fixes #1635
|
this needs one more commit, to undo the sbt build setting to avoid including the Position.scala file, coming real soon |
|
Ready for review |
|
👍 from me; I'll ask and see if we can get someone from the list to confirm that everything works as expected in the land of JARing. |
|
Hee, I saw you already did that ;) |
|
We have confirmation from the list that this is working. 👍 |
farmdawgnation
added a commit
that referenced
this pull request
Nov 16, 2014
Renaming the Position.scala file to ScalaPosition.scala to avoid class name collisions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name conflicts with the private class
fixes #1635