Mongo async support #1829
Merged
Mongo async support #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limit scope of privates in MongoAsync CR fixes use upsert parameter
…ules.defaultWriteConcern.
|
Unless someone wants to take a look at this, I'll merge it in a couple more days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains all of Marek's work, plus I added some tests and updated MongoTestKit.
I also redid MongoAsync.defineDb to take a
MongoDatabaseinstead of(MongoClient, String). This allows the user to configure theMongoDatabasehowever they like. Because of this, I removed the setting of the CodecRegistry. This will have to be done by the user. An example is provided in the comments.