Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix watching VPP events #1640

Merged
merged 3 commits into from
Mar 13, 2020
Merged

Conversation

ondrej-fabry
Copy link
Member

@ondrej-fabry ondrej-fabry commented Mar 13, 2020

This PR contains these changes:

  • fixes watching VPP events after reconnection of VPP
  • properly handles unsubscribing from VPP notifications
  • sets ReconnectResync to true by default

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #1640 into master will increase coverage by 1.09%.
The diff coverage is 54.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1640      +/-   ##
==========================================
+ Coverage   57.75%   58.85%   +1.09%     
==========================================
  Files         495      288     -207     
  Lines       40353    23474   -16879     
==========================================
- Hits        23307    13816    -9491     
+ Misses      14600     8531    -6069     
+ Partials     2446     1127    -1319
Flag Coverage Δ
#e2e ?
#unittests 58.85% <54.28%> (-0.19%) ⬇️

@ondrej-fabry ondrej-fabry merged commit 0650e92 into ligato:master Mar 13, 2020
@ondrej-fabry ondrej-fabry deleted the fix-events branch March 13, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants