fix: maps caching prometheus gauges weren't really used #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech>
Codecov Report
@@ Coverage Diff @@
## master #1741 +/- ##
==========================================
- Coverage 57.27% 55.71% -1.57%
==========================================
Files 606 372 -234
Lines 44282 27778 -16504
==========================================
- Hits 25362 15476 -9886
+ Misses 15982 10828 -5154
+ Partials 2938 1474 -1464
Flags with carried forward coverage won't be shown. Click here to find out more. |
ondrej-fabry
approved these changes
Oct 12, 2020
NotSoFancyName
pushed a commit
to NotSoFancyName/vpp-agent
that referenced
this pull request
Oct 13, 2020
Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Milan Lenco milan.lenco@pantheon.tech