Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support refspec, or syntactic sugar for specifying a github pull request #35

Closed
adriaanm opened this issue Jul 30, 2013 · 5 comments
Closed

Comments

@adriaanm
Copy link
Contributor

in pr validation, we'd like to be able to specify a pullrequest, either as a ref (refs/pull/NNN/head) or using a nicer syntax specific for github, e.g., by parsing github urls to commits or pullrequests, as done by the hub CLI for github

@adriaanm
Copy link
Contributor Author

(to clarify, the default refspec passed to git fetch does not expose the pullrequest refs on github)

@cunei
Copy link

cunei commented Nov 18, 2013

@adriaanm: Pull request #78 fully supports Github pull request refs.

@cunei cunei closed this as completed in 1619f2e Nov 18, 2013
jsuereth added a commit that referenced this issue Nov 18, 2013
@adriaanm
Copy link
Contributor Author

Cool! Could you give an example of how to use it to fetch a PR on scala/scala, say?

@cunei
Copy link

cunei commented Nov 19, 2013

The form is just:

{
  name: scala
  system: scala
  uri: "git://github.com/scala/scala.git#pull/3122/head"
}

This is only available in master, however. I will soon set up nightly builds, so that you can have access to the most recent dbuild snapshots.

@adriaanm
Copy link
Contributor Author

Cool! BTW, we've had great results with Travis CI. Ping me -- I'd be happy to share our experience.
Essentially, something like https://github.com/scala/scala-xml/blob/master/.travis.yml. We'll have to get a license to validate private repos though. I personally think it's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants