Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt 1.5 (was 1.4) #608

Closed
wants to merge 2 commits into from
Closed

sbt 1.5 (was 1.4) #608

wants to merge 2 commits into from

Conversation

SethTisue
Copy link
Collaborator

No description provided.

@SethTisue
Copy link
Collaborator Author

SethTisue commented Mar 15, 2021

Hey @eed3si9n (and cc @dwijnand, though he's on break this week and next)

[error] /home/travis/build/lightbend/mima/project/MimaSettings.scala:16:27: @nowarn annotation does not suppress any warnings
[error]     mimaPreviousArtifacts := Set(pluginProjectID.value.withRevision(mimaPreviousVersion)
[error]                           ^
[error] /home/travis/build/lightbend/mima/project/MimaSettings.scala:19:33: @nowarn annotation does not suppress any warnings
[error]     mimaReportSignatureProblems := true,
[error]                                 ^
[error] /home/travis/build/lightbend/mima/project/MimaSettings.scala:20:28: @nowarn annotation does not suppress any warnings
[error]     mimaBinaryIssueFilters ++= Seq(
[error]                            ^
[error] three errors found

This looks some kind of consequence of the 2.12.13 upgrade? Note that @nowarn appears nowhere in this repo.

This was caught by the Scala community build.

@SethTisue
Copy link
Collaborator Author

offhand I'm guessing what's needed here is a 2.12.x backport of scala/scala#9491 (cc @lrytz)

@eed3si9n
Copy link

Yup. pure expression fix. I think we're getting closer tho since there's a way to suppress that no-warn-nowarn - sbt/sbt#6363

Base automatically changed from master to main March 19, 2021 19:29
@SethTisue SethTisue marked this pull request as ready for review March 22, 2021 15:54
@SethTisue
Copy link
Collaborator Author

yay, fixed in 1.5.0-RC2.

@SethTisue
Copy link
Collaborator Author

SethTisue commented Mar 26, 2021

closing — once 1.5.0 final is out, Scala Steward will submit an upgrade, I believe

@SethTisue SethTisue closed this Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants