Allow introducing new signatures, ignore non-generic signatures #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new version has a signature and the old version didn't, we assume this is compatible. We don't need to check signatures for non-generic methods, since for those it is sufficient to check for a matching descriptor. Introducing or dropping signatures for those isn't relevant to compatibility.
raboof
force-pushed
the
allow-introducing-new-signatures
branch
from
90169aa
to
cca34a8
Compare
|
(not really planning to work on this further for the forseeable future, so closing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new version has a signature and the old version didn't,
we assume this is compatible.
We don't need to check signatures for non-generic methods, since
for those it is sufficient to check for a matching descriptor.
Introducing or dropping signatures for those isn't relevant to
compatibility.
Hopefully fixes #693