Fix option_support_large_channel channel_announcement feature pairity #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes no sense to "require" all payments be greater than 2^24 msat as a routing node, so it should always be odd (ie optional).
rustyrussell
added a commit
to rustyrussell/lightning-rfc
that referenced
this pull request
May 8, 2020
…ncement. Turns out Eclair doesn't, and as c-lightning 0.8.2 implemented and Matt noticed in lightning#770, it should have been ODD anyway! See also: ElementsProject/lightning#3703 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
17 tasks
cdecker
changed the title
|
Definitely a sensible change, but as there is no reason to announce this feature in the announcement at all, I'd go for #773 instead, after all the channel is either larger than 2^24 msat or it isn't and the channel outpoint already conveys this fact. |
|
Agreed, at least using |
cdecker
pushed a commit
that referenced
this pull request
May 11, 2020
…ncement. Turns out Eclair doesn't, and as c-lightning 0.8.2 implemented and Matt noticed in #770, it should have been ODD anyway! See also: ElementsProject/lightning#3703 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes no sense to "require" all payments be greater than 2^24
msat as a routing node, so it should always be odd (ie optional).