Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeAnnouncement not sent #2259

Closed
joostjager opened this issue May 3, 2023 · 3 comments
Closed

NodeAnnouncement not sent #2259

joostjager opened this issue May 3, 2023 · 3 comments

Comments

@joostjager
Copy link

joostjager commented May 3, 2023

I am trying to connect ldk-sample and lnd, but it seems that ldk isn't sending out its NodeAnnouncement.

Repro:

  • Run lnd v0.16.2-beta and ldk-sample 7aceee96f2642d6dd7ef391a4d25df08cc3b9c2d (log on gossip level)
  • lncli connect
  • lncli openchannel
  • Mine 6 blocks
  • -> Channel is now active on both sides
  • -> lncli describegraph has no info on ldk node. Waiting several minutes for the 60s timer to fire doesn't make a difference.
        {
            "last_update": 0,
            "pub_key": "025573862d8cac78b7d9c6d7e59bc682b55685c8d56cb5fda119459540731c756d",
            "alias": "",
            "addresses": [
            ],
            "color": "#000000",
            "features": {
            },
            "custom_records": {
            }
        },

Logs attached. In these logs you can see that I also tried to restart, but didn't fix it either.

LDK log: logs.txt
LND log: lnd.log

@TheBlueMatt
Copy link
Collaborator

The LDK log attached doesn't look to have had broadcast_node_announcement called, looking at the sample it looks like it won't bother broadcasting if no listening addresses are configured, I assume that's what you're hitting here? I suppose that's a bug, we should be announcing a node announcement even if we don't have any addresses as we need to tell the world we support variable_length_onion and onion_messages these days.

@TheBlueMatt
Copy link
Collaborator

@joostjager
Copy link
Author

Yes, that fixed it. Thanks.

@wpaulino wpaulino closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants