Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lndclient: Use field ValueMsat in invoice to avoid rounding #64

Merged
merged 1 commit into from
Aug 19, 2021
Merged

lndclient: Use field ValueMsat in invoice to avoid rounding #64

merged 1 commit into from
Aug 19, 2021

Conversation

sbres
Copy link
Contributor

@sbres sbres commented Aug 18, 2021

Change AddInvoice method to avoid invoice rounding to sat by using the Invoice field ValueMsat instead.

@sbres
Copy link
Contributor Author

sbres commented Aug 18, 2021

Related to issue #63

guggero
guggero approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM 🎉

@guggero guggero requested a review from carlaKC August 19, 2021 07:56
carlaKC
carlaKC approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@guggero guggero merged commit b6a1ce0 into lightninglabs:master Aug 19, 2021
@guggero guggero mentioned this pull request Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero approved these changes

@carlaKC carlaKC carlaKC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbres @guggero @carlaKC