-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump lnd to version v0.18.0-beta #485
Conversation
ca966a2
to
e6a8b1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
@@ -9,7 +9,7 @@ import ( | |||
|
|||
"github.com/btcsuite/btcd/btcec/v2" | |||
secp "github.com/decred/dcrd/dcrec/secp256k1/v4" | |||
gomock "github.com/golang/mock/gomock" | |||
gomock "go.uber.org/mock/gomock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, so this is a fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, apparently the original one was archived. Found out while attempting to fix the broken unit test by upgrading the mock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one minor comment 🚀! Thanks a lot
Pull Request Checklist
used.