Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lnd to version v0.18.0-beta #485

Merged
merged 4 commits into from
May 31, 2024
Merged

Bump lnd to version v0.18.0-beta #485

merged 4 commits into from
May 31, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented May 31, 2024

Pull Request Checklist

  • LndServices minimum version has been updated if new lnd apis/fields are
    used.

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@@ -9,7 +9,7 @@ import (

"github.com/btcsuite/btcd/btcec/v2"
secp "github.com/decred/dcrd/dcrec/secp256k1/v4"
gomock "github.com/golang/mock/gomock"
gomock "go.uber.org/mock/gomock"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, so this is a fork?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, apparently the original one was archived. Found out while attempting to fix the broken unit test by upgrading the mock.

Copy link

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except one minor comment 🚀! Thanks a lot

go.mod Outdated Show resolved Hide resolved
@guggero guggero merged commit 4000ec8 into master May 31, 2024
6 checks passed
@guggero guggero deleted the lnd-18 branch May 31, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants