Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loadtest: add multi send test #558

Merged
merged 3 commits into from
Oct 10, 2023
Merged

loadtest: add multi send test #558

merged 3 commits into from
Oct 10, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Oct 10, 2023

Fixes #469.

Depends on #556.

This is the last piece to address our initial requirements for the load test.

cc @calvinrzachman:

I changed some things around and it's now possible to either specify a test case in the config (test-case=xxx, if you don't specify anything, all two tests will run) or in the command line (-test.run="TestPerformance/send").
There are a couple of new test specific settings we can specify (and I renamed the batch-size config to mint-test-batch-size).
Here are the default values for these new config values:

mint-test-batch-size=200
send-test-num-sends=50
send-test-num-assets=1
send-test-send-type=1

@guggero guggero requested a review from Roasbeef October 10, 2023 17:49
@guggero guggero force-pushed the loadtest-send-asset branch 2 times, most recently from 128e682 to d7f826d Compare October 10, 2023 19:45
Because we are running a compiled Go test case, we can't use any custom
flags as the internal flag parser only accepts the pre-defined
"-test.XXX" flags. But we couldn't use those either because we attempted
to also parse the flags with the lnd flag parsing library.

This commit fixes the issue by removing any custom flag parsing and
allowing test cases to be specified using the -test.run flag.
For example:

	-test.run="^TestPerformance/mint_batch_stress$"
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔩

itest/loadtest/load_test.go Show resolved Hide resolved
@Roasbeef Roasbeef merged commit abdfae2 into main Oct 10, 2023
14 checks passed
@guggero guggero deleted the loadtest-send-asset branch October 10, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Implement Performance Testing Binary for tapd Instances
3 participants